Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function signatures of imap_delete and imap_undelete #8537

Merged
merged 3 commits into from Oct 6, 2022
Merged

Fixed function signatures of imap_delete and imap_undelete #8537

merged 3 commits into from Oct 6, 2022

Conversation

ppdeblieck
Copy link
Contributor

Fixed issue from #8533

@ppdeblieck ppdeblieck mentioned this pull request Oct 5, 2022
Closed
@orklah
Copy link
Collaborator

orklah commented Oct 5, 2022

Cool thanks!

There's a imap_undelete you need to update too on callmap_81_delta.php

@orklah
Copy link
Collaborator

orklah commented Oct 6, 2022

Oh, those were actually functions where we noticed something was wrong but not anymore.

Could you remove those two in InternalCallMapHandlerTest::$ignoredFunctions ? This will make the last test pass

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Oct 6, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 6, 2022

Thanks!

@orklah orklah merged commit b6ddcdf into vimeo:4.x Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppdeblieck @orklah