Review usages of String_ to correctly handle escaping

[AndrolGenhald]

String_::$value unescapes the string, String_::$attributes["rawValue"] was recently added for this. We should upgrade the parser version and fix these issues.

• https://psalm.dev/r/c53ed4f377 (we might also have to change how we handle escaping in single and double quote literal types)
  • Interestingly this doesn't work either
• https://psalm.dev/r/cc297a99cb (actually correct)
• https://psalm.dev/r/30427475aa
• TODO go through and find more...

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c53ed4f377

<?php

/**
 * @return "\t"
 */
function foobar(): string
{
    return "\t";
}

Psalm output (using commit f2f211c):

ERROR: InvalidReturnStatement - 8:12 - The inferred type ''\t'' does not match the declared return type ''\\t'' for foobar

ERROR: InvalidReturnType - 4:12 - The declared return type ''\\t'' for foobar is incorrect, got ''\t''

https://psalm.dev/r/7c454c91bd

<?php

/**
 * @return "	"
 */
function foobar(): string
{
    return "\t";
}

Psalm output (using commit f2f211c):

ERROR: InvalidReturnStatement - 8:12 - The inferred type ''\t'' does not match the declared return type '' '' for foobar

ERROR: InvalidReturnType - 4:12 - The declared return type '' '' for foobar is incorrect, got ''\t''

https://psalm.dev/r/cc297a99cb

<?php

/** @var array<string, true> */
$arr = ["\t" => true];
if (isset($arr["\t"])) {
    $shouldBePossiblyUndefinedArrayStringOffset = $arr["	"];
    /** @psalm-trace $shouldBePossiblyUndefinedArrayStringOffset */;
}

Psalm output (using commit f2f211c):

INFO: Trace - 7:68 - $shouldBePossiblyUndefinedArrayStringOffset: true

https://psalm.dev/r/30427475aa

<?php

$arr = ["\\test" => true];
$unset = $arr['\\test'];
$unset2 = $arr["\\\\test"];

Psalm output (using commit f2f211c):

ERROR: InvalidArrayOffset - 5:11 - Cannot access value on variable $arr using offset value of '\\test', expecting '\test'

INFO: MixedAssignment - 5:1 - Unable to determine the type that $unset2 is being assigned to

[AndrolGenhald]

Ok, part of this was because I was dumb and was using "\\" in Psalm's tests when it actually needs to be "\\\\" to represent "\\" because the whole thing is in single quotes. I think there are related issues though so I'll leave this open.