Psalm is unaware of a handful of methods on the various core reflection classes

[ollieread]

I've only created examples for the ones that I encountered, but if my understanding is correct, and stubs/Reflection.phpstub is how Psalm understands reflection classes, there is a lot missing.

ReflectionProperty::hasDefaultValue() https://psalm.dev/r/7de1ce446b
ReflectionProperty::isPromoted() https://psalm.dev/r/0b4cc46fd2
ReflectionParameter::isPromoted() https://psalm.dev/r/62322a32a6

If my assumption/understanding is correct, I'm more than happy to create a PR that updates all of the Reflection stubs to accurately match what is available.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/7de1ce446b

<?php

class PropertyWrapper {
    private ReflectionProperty $reflection;
    
    public function __construct(ReflectionProperty $reflection)
    {
        $this->reflection = $reflection;
    }
    
    public function hasDefault(): bool
    {
        return $this->reflection->hasDefaultValue();
    }
}

Psalm output (using commit a9f4148):

INFO: MixedReturnStatement - 13:16 - Could not infer a return type

INFO: MixedInferredReturnType - 11:35 - Could not verify return type 'bool' for PropertyWrapper::hasDefault

https://psalm.dev/r/0b4cc46fd2

<?php

class PropertyWrapper {
    private ReflectionProperty $reflection;
    
    public function __construct(ReflectionProperty $reflection)
    {
        $this->reflection = $reflection;
    }
    
    public function isPromoted(): bool
    {
        return $this->reflection->isPromoted();
    }
}

Psalm output (using commit a9f4148):

INFO: MixedReturnStatement - 13:16 - Could not infer a return type

INFO: MixedInferredReturnType - 11:35 - Could not verify return type 'bool' for PropertyWrapper::isPromoted

https://psalm.dev/r/62322a32a6

<?php

class PropertyWrapper {
    private ReflectionParameter $reflection;
    
    public function __construct(ReflectionParameter $reflection)
    {
        $this->reflection = $reflection;
    }
    
    public function isPromoted(): bool
    {
        return $this->reflection->isPromoted();
    }
}

Psalm output (using commit a9f4148):

INFO: MixedReturnStatement - 13:16 - Could not infer a return type

INFO: MixedInferredReturnType - 11:35 - Could not verify return type 'bool' for PropertyWrapper::isPromoted

[ollieread]

It is also unaware of Attribute::$flags https://psalm.dev/r/8f628693b7, which I believe is controlled by stubs/Php80.phpstub

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8f628693b7

<?php

class AttributeWrapper {
    private Attribute $attribute;
    
    public function __construct(Attribute $attribute)
    {
        $this->attribute = $attribute;
    }
    
    public function getFlags(): int
    {
        return $this->attribute->flags;
    }
    
    public function isRepeatable(): bool
    {
        return (bool)($this->getFlags() & Attribute::IS_REPEATABLE);
    }
}

Psalm output (using commit a9f4148):

INFO: MixedReturnStatement - 13:16 - Could not infer a return type

INFO: MixedInferredReturnType - 11:33 - Could not verify return type 'int' for AttributeWrapper::getFlags

[AndrolGenhald]

I'm more than happy to create a PR

Go for it! Just be sure to use the correct Phpxx.phpstub for things that don't exist in all PHP versions.

[ollieread]

I'm more than happy to create a PR

Go for it! Just be sure to use the correct Phpxx.phpstub for things that don't exist in all PHP versions.

Sorry, this got buried under mountain if other things. If this still hasn't been fixed I will take a look and create a PR for the reflection stubs.