Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct name of ErrorException::__construct $line param #7659

Merged
merged 1 commit into from Feb 13, 2022
Merged

Correct name of ErrorException::__construct $line param #7659

merged 1 commit into from Feb 13, 2022

Conversation

zopsicle
Copy link
Contributor

@zopsicle zopsicle commented Feb 13, 2022 •
edited

Fixes #7658.

Thanks to @weirdan for the help!

Do I have to add a regression test?

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 13, 2022
@weirdan
Copy link
Collaborator

weirdan commented Feb 13, 2022

No, it's fine as it is

@weirdan weirdan merged commit 7f304be into vimeo:4.x Feb 13, 2022
@weirdan
Copy link
Collaborator

weirdan commented Feb 13, 2022

Thanks!

@zopsicle zopsicle deleted the ErrorException-__construct-line-parameter-name branch February 13, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter $line does not exist on function ErrorException::__construct
2 participants
@zopsicle @weirdan