New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevented crashes on array_map(...)
#7321
Prevented crashes on array_map(...)
#7321
Conversation
array_map(...)
array_map(...)
maybe add a TODO to signal that we're missing something at that place? |
Are we? |
I didn't look in details what the code here does but I'd expect first class callable to be replaced with a callable or something, no? |
With this patch applied, we already do the best we can short of supporting generic closures. For |
Nevermind then 🙂 what do you call generic closures? |
E.g. this |
This actually results in a bug:
That method See: https://github.com/nikic/PHP-Parser/blob/master/lib/PhpParser/Node/Expr/FuncCall.php |
FuncCall extends CallLike which has isFirstClassCallable method. Mind posting the entire stack along with your installed version of PHP-Parser in a new issue? |
@orklah I missed the extends! Bad me! Looking through code. Probably a red-herring! |
Fixes #7305