Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve negated reconciliation logic #7261

Merged
merged 2 commits into from Jan 1, 2022

Conversation

muglug
Copy link
Collaborator

@muglug muglug commented Jan 1, 2022

This just moves isset handling to its rightful place, and also removes a few impossible conditionals (!=isset is never seen).

@muglug muglug added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 1, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 1, 2022

Thanks!

@orklah orklah merged commit 6c176bb into master Jan 1, 2022
@muglug muglug deleted the muglug-improve-negated-reconciliation-logic branch January 1, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants