Don't output console links in CI env #7049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are all but useless there, and are actually causing issue with GHA output. Fixes vimeo#7047
weirdan
added
the
release:fix
|
Test failure is legit, but not being able to rely on superglobals makes it quite a bit harder. |
This has to happen before third-party autoloader has a chance to mess up global environment.
orklah
approved these changes
Dec 4, 2021
|
Thanks for fixing the issue ! Question: Could we consider using https://packagist.org/packages/ondram/ci-detector for checking if it is running in CI ? |
|
Yeah, we could consider it if needed. Do you happen to use an exotic CI environment? |
|
On my side no, I only use Github and Gitlab. |
|
That said, that package support quite a large amount of CI system that I was not even aware of, check their README file ! |
|
That was kinda my point, if we weren't aware they existed, it will be the case for most people too :) If we have a feedback from a user, we'll consider making the change, but I try not to add dependencies for things I'm not sure are needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are all but useless there, and are actually causing an issue with GHA output.
Fixes #7047