Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit output cluttered #7028

Closed
rarila opened this issue Nov 30, 2021 · 3 comments · Fixed by #7031
Closed

PHPUnit output cluttered #7028

rarila opened this issue Nov 30, 2021 · 3 comments · Fixed by #7031
Labels

Comments

@rarila
Copy link
Contributor

rarila commented Nov 30, 2021

PHPUnit output gets cluttered like this:

[...]
............................................................. 2196 / 6542 ( 33%)
................................................Target PHP version: 8.0 (inferred from current PHP version)
............. 2257 / 6542 ( 34%)
............................................................. 2318 / 6542 ( 35%)
............................................................. 2379 / 6542 ( 36%)
[...]
...S......................................................... 2928 / 6542 ( 44%)
............................................................. 2989 / 6542 ( 45%)
............................................................. 3050 / 6542 ( 46%)
...........................Target PHP version: 8.0 (inferred from current PHP version)
.Target PHP version: 8.0 (inferred from current PHP version)
.Target PHP version: 8.0 (inferred from current PHP version)
.Target PHP version: 8.0 (inferred from current PHP version)
.Target PHP version: 8.0 (inferred from current PHP version)
.............................. 3111 / 6542 ( 47%)
............................................................. 3172 / 6542 ( 48%)
[...]

Probably introduced by #7006

Could be that some tests call $this->progress->write($this->generatePHPVersionMessage()); that finally ends up in fwrite(STDERR, $message); and doesn’t get captured by PHPUnit that way.

PS: don’t use paratest to reproduce as there the output seems to be filtered

@psalm-github-bot
Copy link

Hey @rarila, can you reproduce the issue on https://psalm.dev ?

@weirdan weirdan added the bug label Nov 30, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 30, 2021

Indeed. I wonder why those tests don't use VoidProgress.

@weirdan
Copy link
Collaborator

weirdan commented Nov 30, 2021

Ah, they may use it, but Progress::write() is not a dummy method, unlike all other. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants