First-class callable

[userqq]

Hi, I'm trying to get works psalm with php8.1 syntax, but getting error
Uncaught AssertionError: assert(!$this->isFirstClassCallable()) in /app/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:36
when trying to inspect following line

array_map($this->handle(...), $message->parameters['messages']->value);

When I trying to run the snippet https://psalm.dev/r/399d485cde , https://psalm.dev/check responds with 500 error:

<b>Warning</b>:  Undefined property: PhpParser\Node\VariadicPlaceholder::$name in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php</b> on line <b>118</b><br />
<br />
<b>Warning</b>:  Undefined property: PhpParser\Node\VariadicPlaceholder::$value in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php</b> on line <b>177</b><br />
<br />
<b>Warning</b>:  Undefined property: PhpParser\Node\VariadicPlaceholder::$value in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php</b> on line <b>178</b><br />
<br />
<b>Warning</b>:  Undefined property: PhpParser\Node\VariadicPlaceholder::$value in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php</b> on line <b>200</b><br />
{"error":{"message":"\/vendor\/vimeo\/psalm\/src\/Psalm\/Internal\/Analyzer\/Statements\/ExpressionAnalyzer.php: Psalm\\Internal\\Analyzer\\Statements\\ExpressionAnalyzer::analyze(): Argument #2 ($stmt) must be of type PhpParser\\Node\\Expr, null given, called in \/vendor\/vimeo\/psalm\/src\/Psalm\/Internal\/Analyzer\/Statements\/Expression\/Call\/ArgumentsAnalyzer.php on line 200","line_from":35,"type":"psalm_error"}}

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/399d485cde

<?php

class Foo
{
	public function bar(): array
    {
        return $this->map($this->baz(...), [1, 2, 3]);
    }

    private function baz(int $val): int
    {
        return $val * 2;
    }

    private function map(callable $callback, array $val): array
    {
        $result = [];
        foreach ($val as $key => $value) {
            $result[$key] = $callback($value);
        }

        return $result;
    }
}

var_dump((new Foo)->bar());

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php: Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer::analyze(): Argument #2 ($stmt) must be of type PhpParser\Node\Expr, null given, called in /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php on line 200

[weirdan]

Can you try parsing the source file with vendor/bin/php-parse? If that fails it needs to be reported upstream: https://github.com/nikic/PHP-Parser/issues

[orklah]

It's not a PHP-Parser issue, it's indirectly due to #6628

in PHP-Parser 4.13, the argument list (for a MethodCall in this case) is not longer a list of Args due to PHP support for first class callable. It can now be a VariadicPlaceholder also.

In #6628, I replaced every use of MethodCall::args (and others) by MethodCall::getArgs() in order to fallback to a method that returns the same list of Args as before.

However, PHP-Parser does an assert on MethodCall::args in order to check that it's not a first class callable to be able to make sure it only return Args.

The effect of that is that Psalm doesn't have support for first class callable (it would have failed to parse in PHP-Parser 4.12 and now it fails on the assertion)

This makes this issue very related to #6412, if not a duplicate

[FractalizeR]

Any news here? Stumbled over the same problem

[orklah]

Actually, this should have been closed by #7113. @FractalizeR if you could make sure your use case work in latest master, it would help checking everything works. Please open a new issue if you encounter difficulties

[FractalizeR]

Latest master (pointing composer to dev-master branch) didn't work. The error is still:

psalm: Target PHP version: 8.1 (inferred from composer.json)
Scanning files...
Analyzing files...
Uncaught AssertionError: assert(!$this->isFirstClassCallable()) in <...>/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:36
Stack trace:
#0 <...>/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php(36): assert(false, 'assert(!$this->...')
#1 <...>/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeCollector.php(358): PhpParser\Node\Expr\CallLike->getArgs()

[orklah]

@FractalizeR can you please open a new issue?

[userqq]

@FractalizeR can you please open a new issue?

@orklah I did - #7196