Enums cases as attribute params

[weirdan]

Enums in attributes are not properly detected for their types https://psalm.dev/r/3615c731dc?php=8.1 (simplified)

Originally posted by @jpresutti in #6425 (comment)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/3615c731dc

<?php
class CreateController {
    #[Param(paramType: ParamType::FLAG)]
    public function actionGet(): void {}
}

use Attribute;

#[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
class Param {
    public function __construct(
        public ParamType $paramType = ParamType::PARAM
    ) {
    }   
}

enum ParamType {
    case FLAG;
    case PARAM;
}

Psalm output (using commit fdf3a8d):

ERROR: InvalidArgument - 3:24 - Argument 1 of Param::__construct expects ParamType, "Psalm could not infer this type" provided

[weirdan]

Fixed in #6984

[jpresutti]

Thank you for the super quick turnaround on this!

[weirdan]

I think I've seen @muglug fixing some issues within 15 minutes of them being reported, so we still have some room for improvement 😆

[jpresutti]

I think I've seen @muglug fixing some issues within 15 minutes of them being reported, so we still have some room for improvement 😆

Either way, @weirdan this was gonna potentially block me from releasing the next version of my framework tomorrow, due to my strict Psalm rule for errorLevel 1 clean with 100% type inference (except in VERY limited cases for psalm-suppress) so this makes me happy.