Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile class-constant #6529

Merged
merged 13 commits into from
Nov 17, 2021
Merged

Reconcile class-constant #6529

merged 13 commits into from
Nov 17, 2021

Conversation

boesing
Copy link
Contributor

@boesing boesing commented Sep 23, 2021 •
edited

Fixes #6480
Fixes #6300

Any help here would be appreciated.

@boesing boesing marked this pull request as draft September 23, 2021 23:51
@boesing boesing changed the title Reconcile class-constant WIP: Reconcile class-constant Sep 23, 2021
@boesing boesing force-pushed the bugfix/class-constant-reconciliation branch from 1262daf to e01af5b Compare September 24, 2021 00:25
@boesing boesing marked this pull request as ready for review September 24, 2021 00:26
@boesing boesing force-pushed the bugfix/class-constant-reconciliation branch from e01af5b to d197614 Compare September 24, 2021 00:27
@boesing boesing requested a review from orklah September 26, 2021 11:08
@boesing boesing force-pushed the bugfix/class-constant-reconciliation branch from 21d6a54 to 3ce1cce Compare September 26, 2021 11:51
@weirdan weirdan marked this pull request as draft October 12, 2021 18:34
@boesing
bugfix: reconcile class-constant
4962416 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: add Reconciler::RECONCILIATION_* constants
c619164 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: add namespace to test asset
1a543ae 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
refactor: expand test cases and optimize handling of invalid class-co…
3e1be79 
…nstant references

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: quote regular expression
a050ff2 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the bugfix/class-constant-reconciliation branch from 4bda179 to a050ff2 Compare November 15, 2021 16:58
@boesing
bugfix: remove preg_quote as that will also quote wildcard
743f570 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
feature: extract class constant by wildcard detection into dedicated …
68abcaa 
…resolver

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: ensure psalm is able to understand already verified types
a2bf87b 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing marked this pull request as ready for review November 15, 2021 17:32
@boesing
bugfix: prevent psalm from yelling about docblock type contradiction
665cea7 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: apply coding standard
765bf93 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing mentioned this pull request Nov 15, 2021
Closed
@boesing boesing requested a review from orklah November 15, 2021 17:44
@boesing boesing changed the title WIP: Reconcile class-constant Reconcile class-constant Nov 15, 2021
@boesing
qa: re-enable skipped test for class constant assertions
dac82e9 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Nov 15, 2021
@boesing
qa: remove useless var annotation and the psalm suppression
62b0a09 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: ensure array_merge has at least one argument
6bf0265 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@weirdan weirdan merged commit 6097e02 into vimeo:master Nov 17, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 17, 2021

Thanks!

@boesing boesing deleted the bugfix/class-constant-reconciliation branch November 21, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah approved these changes

Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert does not provide constant information Asserts with constant wildcards
3 participants
@boesing @weirdan @orklah