Add documentation on callmap editing #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
reviewed
Sep 4, 2021
|
|
||
| Delta files (named `CallMap_<PHP major version><PHP minor version>_delta.php`) | ||
| list the changed that happened in the corresponding PHP version. There are | ||
| three section with self-explanatory names: `aded` (for functions/methods that |
orklah
approved these changes
Sep 4, 2021
There was a problem hiding this comment.
Should we bother explaining here the subtleties like '1 when multiple signature exists, & for reference parameters, the fact that Psalm does not follow signature to the letter when param types or return types are the result of developper errors (typically when param became TypeError later) ? Maybe even that functions in callmap are pure by default?
Or maybe keep those out of the simple guide not to afraid contributors?
|
I intended that as a simple guide indeed. This can be expanded if we observe people confused by subtleties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.