InvalidReturnType incorrect error

[KorDum]

For example
https://psalm.dev/r/d75a4c2020
Code above throws exception or returns string.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d75a4c2020

<?php

class Test {
	private int $retryAttempts = 10;

    private function getResult(): string
    {
        // return tring or throw exception whatever
        throw new Exception();
    }

    private function getResultWithRetry(): string
    {
        $attempt = 1;

        while (true) {
            try {
                return $this->getResult();
            } catch (Throwable $exception) {
                if ($attempt >= $this->retryAttempts) {
                    throw $exception;
                }

                $attempt++;

                continue;
            }
        }
    }
}

Psalm output (using commit eb973ab):

ERROR: InvalidReturnType - 12:44 - Not all code paths of Test::getResultWithRetry end in a return statement, return type string expected

[weirdan]

As a workaround, you can throw exception after the while block: https://psalm.dev/r/1e77336875

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/1e77336875

<?php

class Test {
	private int $retryAttempts = 10;

    private function getResult(): string
    {
        // return tring or throw exception whatever
        throw new Exception();
    }

    private function getResultWithRetry(): string
    {
        $attempt = 1;

        while (true) {
            try {
                return $this->getResult();
            } catch (Throwable $exception) {
                if ($attempt >= $this->retryAttempts) {
                    throw $exception;
                }

                $attempt++;

                continue;
            }
        }
        throw new RuntimeException('should never happen');
    }
}

Psalm output (using commit eb973ab):

No issues!

[KorDum]

As a workaround, you can throw exception after the while block: https://psalm.dev/r/1e77336875

Sorry, but it is incorrect dead code. IDE and phpstan will sound the alarm.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/1e77336875

<?php

class Test {
	private int $retryAttempts = 10;

    private function getResult(): string
    {
        // return tring or throw exception whatever
        throw new Exception();
    }

    private function getResultWithRetry(): string
    {
        $attempt = 1;

        while (true) {
            try {
                return $this->getResult();
            } catch (Throwable $exception) {
                if ($attempt >= $this->retryAttempts) {
                    throw $exception;
                }

                $attempt++;

                continue;
            }
        }
        throw new RuntimeException('should never happen');
    }
}

Psalm output (using commit eb973ab):

No issues!

[orklah]

simplified:
https://psalm.dev/r/bd185e9e6a

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/bd185e9e6a

<?php

function getResultWithRetry(): string
{
    while (true) {
        return '';
    }
}

Psalm output (using commit eb973ab):

ERROR: InvalidReturnType - 3:32 - Not all code paths of getResultWithRetry end in a return statement, return type string expected