Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of getInnerIterator which is always returning an iterator #6359

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Update return type of getInnerIterator which is always returning an iterator #6359

merged 1 commit into from
Aug 26, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Aug 24, 2021

When an iterator implements OuterIterator interface, it has the getInnerIterator method, which is always returning an iterator.

This PR:

  • Update CallMap.php and CallMap_historical.php to reflect this.

@drupol drupol marked this pull request as ready for review August 25, 2021 11:26
@weirdan
Copy link
Collaborator

weirdan commented Aug 26, 2021

Note: even though docs say it returns ?Iterator the stated intention of OuterIterator is to implement it in iterator wrapper classes, so the null part in that union doesn't really make sense.

@weirdan weirdan merged commit 5138be3 into vimeo:master Aug 26, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 26, 2021

Thanks!

@drupol
Copy link
Contributor Author

drupol commented Aug 27, 2021

Thanks for merging !

@drupol drupol deleted the fix/update-iterator-getinneriterator-return-type branch August 27, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants