Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't report UnusedSuppressions in non project dirs #6344

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Aug 19, 2021

This will fix #5356

Thanks to @simPod for the reproducer!

@orklah
Copy link
Collaborator Author

orklah commented Aug 19, 2021

Oh, the irony.

Psalm's test cases fake files are not included in project files so this was failing the test. I added a fake file and used it to make the errors go away

@weirdan weirdan merged commit 3cb28e6 into vimeo:master Aug 19, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnusedPsalmSuppress reported in vendor dir
2 participants