Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add missing TNonEmptyMixed to Atomic#create #6323

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

boesing
Copy link
Contributor

@boesing boesing commented Aug 17, 2021

Uncaught Exception: Unrecognized type non-empty-mixed░░░░░░░  1621 / 6083 (26%)
Stack trace in the forked worker:
#0 /vendor/vimeo/psalm/src/Psalm/Internal/Type/TypeParser.php(87): Psalm\Type\Atomic::create('non-empty-mixed', NULL, Array, Array)
#1 /vendor/vimeo/psalm/src/Psalm/Type.php(75): Psalm\Internal\Type\TypeParser::parseTokens(Array, NULL, Array)
#2 /vendor/vimeo/psalm/src/Psalm/Internal/Type/NegatedAssertionReconciler.php(158): Psalm\Type::parseString('non-empty-mixed')
#3 /vendor/vimeo/psalm/src/Psalm/Internal/Type/AssertionReconciler.php(115): Psalm\Internal\Type\NegatedAssertionReconciler::reconcile(Object(Psalm\Internal\Analyzer\StatementsAnalyzer), 'non-empty-mixed', false, false, Object(Psalm\Type\Union), Array, 'mixed', '$value', false, NULL, Array, 0)
#4 /vendor/vimeo/psalm/src/Psalm/Type/Reconciler.php(197): Psalm\Internal\Type\AssertionReconciler::reconcile('in-array-non-em...', Object(Psalm\Type\Union), '$value', Object(Psalm\Internal\Analyzer\StatementsAnalyzer), false, Array, NULL, Array, 0, false)
#5 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Block/IfElseAnalyzer.php(343): Psalm\Type\Reconciler::reconcileKeyedTypes(Array, Array, Array, Array, Array, Object(Psalm\Internal\Analyzer\StatementsAnalyzer), Array, false, Object(Psalm\CodeLocation))
#6 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/StatementsAnalyzer.php(491): Psalm\Internal\Analyzer\Statements\Block\IfElseAnalyzer::analyze(Object(Psalm\Internal\Analyzer\StatementsAnalyzer), Object(PhpParser\Node\Stmt\If_), Object(Psalm\Context))
#7 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/StatementsAnalyzer.php(185): Psalm\Internal\Analyzer\StatementsAnalyzer::analyzeStatement(Object(Psalm\Internal\Analyzer\StatementsAnalyzer), Object(PhpParser\Node\Stmt\If_), Object(Psalm\Context), Object(Psalm\Context))
#8 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php(433): Psalm\Internal\Analyzer\StatementsAnalyzer->analyze(Array, Object(Psalm\Context), Object(Psalm\Context), true)
#9 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ClassAnalyzer.php(1782): Psalm\Internal\Analyzer\FunctionLikeAnalyzer->analyze(Object(Psalm\Context), Object(Psalm\Internal\Provider\NodeDataProvider), Object(Psalm\Context))
#10 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ClassAnalyzer.php(404): Psalm\Internal\Analyzer\ClassAnalyzer->analyzeClassMethod(Object(PhpParser\Node\Stmt\ClassMethod), Object(Psalm\Storage\ClassLikeStorage), Object(Psalm\Internal\Analyzer\ClassAnalyzer), Object(Psalm\Context), Object(Psalm\Context))
#11 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/FileAnalyzer.php(214): Psalm\Internal\Analyzer\ClassAnalyzer->analyze(Object(Psalm\Context), Object(Psalm\Context))
#12 /vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Analyzer.php(348): Psalm\Internal\Analyzer\FileAnalyzer->analyze(NULL)
#13 /vendor/vimeo/psalm/src/Psalm/Internal/Fork/Pool.php(194): Psalm\Internal\Codebase\Analyzer->Psalm\Internal\Codebase\{closure}(273, '/Users/max/git/...')
#14 /vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Analyzer.php(414): Psalm\Internal\Fork\Pool->__construct(Array, Object(Closure), Object(Closure), Object(Closure), Object(Closure))
#15 /vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Analyzer.php(277): Psalm\Internal\Codebase\Analyzer->doAnalysis(Object(Psalm\Internal\Analyzer\ProjectAnalyzer), 7)
#16 /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php(640): Psalm\Internal\Codebase\Analyzer->analyzeFiles(Object(Psalm\Internal\Analyzer\ProjectAnalyzer), 7, false, true)
#17 /vendor/vimeo/psalm/src/Psalm/Internal/Cli/Psalm.php(359): Psalm\Internal\Analyzer\ProjectAnalyzer->check('/Users/max/git/...', true)
#18 /vendor/vimeo/psalm/psalm(4): Psalm\Internal\Cli\Psalm::run(Array)
#19 {main} in /vendor/vimeo/psalm/src/Psalm/Internal/Fork/Pool.php:366

I am not able to create a reproducible error on psalm.dev, but I have something like this which triggers this exception:
https://psalm.dev/r/b77686dd7e

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/b77686dd7e
<?php


class Bar
{
    public function getAll(): array
    {
        return [];
    }
}

class Foo
{
    /**
     * @var Bar
     */
    private $repository;
    
    public function __construct(Bar $repository)
    {
    	$this->repository = $repository;
    }
    
    /** 
     * @param mixed $value 
     * @return bool
     */
	public function isValid($value)
    {
    	$foo = $this->repository->getAll();
        $bar = array_filter(array_column($foo, 'bar'));
        
        if (in_array($value, $bar, true)) {
            return false;
        }
        
        return true;
    }
}
Psalm output (using commit b343ae5):

No issues!

@weirdan weirdan merged commit 285fa13 into vimeo:master Aug 17, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 17, 2021

Thanks!

@boesing boesing deleted the bugfix/atomic-non-empty-mixed branch August 17, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants