Fix issues in php 8.0 delta #6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a last minute change in php 8.0 after the feature freeze, PhpToken::getAll was changed to tokenize Also, https://www.php.net/manual/en/function.mb-get-info has been around since php 4.2 - it's in psalm/dictionaries/CallMap.php already with the same signature. Same for ReflectionNamedType::isBuiltin Also, add signatures for getAttributes. Also, use the same param names for fdiv that are found in reflection in php 8.0 and 8.1 to support named arguments
|
I'm going to fix issues in this PR. |
|
Oh, CallMap.php is using 8.0 as the base. And mb_get_info should be in CallMap_historical.php. I'd assumed that psalm was still using 7.x as a base
Will let you do that since you've already started |
|
Yeah, 'historical' is for 7.0 and below, while |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a last minute change in php 8.0 after the feature freeze,
PhpToken::getAll was changed to tokenize
Also, https://www.php.net/manual/en/function.mb-get-info
has been around since php 4.2 - it's in psalm/dictionaries/CallMap.php
already with the same signature. Same for ReflectionNamedType::isBuiltin
Also, add signatures for getAttributes.
Also, use the same param names for fdiv that are found in reflection in
php 8.0 and 8.1 to support named arguments