Added missing mb_str_split function #6219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Is there a reason why you called the second parameter "limit"? the doc seem to say "length" https://www.php.net/manual/en/function.mb-str-split.php |
weirdan
requested changes
Aug 1, 2021
weirdan
approved these changes
Aug 1, 2021
Oops, well spotted. I copy-pasted part of the signature from mb_split() and missed the difference in name. |
|
It didn't use to matter but now with PHP 8's named parameter, it does :). Thanks for the PR! |
|
Thanks! |
|
I think it can be improved #6324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing mb_str_split() function from PHP 7.4 to dictionaries
Fixes #6217