False-positive UnusedVariable for assignment in if

[gharlan]

https://psalm.dev/r/a2c8c64a3e

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a2c8c64a3e

<?php

abstract class Foo {
    abstract function validate(): bool|string;
    abstract function save(): bool|string;
    
    function bar(): void {
    	if (true === ($result = $this->validate()) && true === ($result = $this->save())) {
            echo 'ok';
        } elseif (is_string($result)) {
            echo $result;
        } else {
            echo 'error';
        }
    }
}

Psalm output (using commit ee778e9):

INFO: UnusedVariable - 8:62 - $result is never referenced or the value is not used

[muglug]

Comparable false-negative InvalidReturn: https://psalm.dev/r/5858e7fc6e

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/5858e7fc6e

<?php

function bar(bool $result): bool {
    if ($result && ($result = rand(0, 1))) {
        return true;
    }

    return $result;
}

Psalm output (using commit ee778e9):

INFO: UnusedVariable - 4:21 - $result is never referenced or the value is not used