Strict int/float comparison for conditional types, improve range return type #5601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect conditional return type due to int/float comparison.
int|string
works as expected: https://psalm.dev/r/b87cd02f3abut
int|float
produces very odd results: https://psalm.dev/r/993cd83eb3Also improve range return type to be
list<float>
if$step
isfloat
(I didn't find any PHP documentation addressing this but it seems to be empirically true: https://3v4l.org/3tcIK).