ArrayAnalyzer int_offset broken

[AndrolGenhald]

For object-like arrays with some keys specified and some not $int_offset assigns the wrong key.
https://psalm.dev/r/1066dc35a8
It's out of order too (assuming object-like arrays are supposed to retain order). Edit: sorting properties on non-list keyed arrays seems to be intentional.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/1066dc35a8

<?php
$a = [1, 'a' => 2, 3];
/** @psalm-trace $a */ // $a is actually [0 => 1, 'a' => 2, 1 => 3];

Psalm output (using commit 42d3bce):

INFO: Trace - 3:69 - $a: array{0: 1, 2: 3, a: 2}

INFO: UnusedVariable - 2:1 - $a is never referenced or the value is not used

[AndrolGenhald]

Should this be allowed?
https://psalm.dev/r/a37bd3cac6
Technically valid, but seems weird.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a37bd3cac6

<?php

/** @return list<int> */
function returnList(): array {
    return [1, 1 => 2, 3];
}

Psalm output (using commit 42d3bce):

ERROR: InvalidReturnStatement - 5:12 - The inferred type 'array{0: 1, 1: 2, 2: 3}' does not match the declared return type 'list<int>' for returnList

ERROR: InvalidReturnType - 3:13 - The declared return type 'list<int>' for returnList is incorrect, got 'array{0: 1, 1: 2, 2: 3}'

[weirdan]

Technically valid, but seems weird.

Looks like a false-positive to me.