Variadic parameters and non-empty-list

[vjik]

https://psalm.dev/r/7f75a28f23

In this example $x can be empty, but psalm understand this as non-empty-list. It is bug.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/7f75a28f23

<?php

$x = [];
$y = [];

$x = [...$x, ...$y];

/** @psalm-trace $x */
$x ? 1 : 0;

Psalm output (using commit d19088b):

ERROR: RedundantCondition - 9:1 - Type non-empty-list<empty> for $x is never falsy

ERROR: TypeDoesNotContainType - 9:10 - Type non-empty-list<empty> for $x is never falsy

INFO: Trace - 9:1 - $x: non-empty-list<empty>

[AndrolGenhald]

I'm seeing several other issues creating arrays with the spread operator, here's a false negative: https://psalm.dev/r/e7aeb5831c
Should be like this: https://psalm.dev/r/2ac2479ad5

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/e7aeb5831c

<?php

/** @return array<array-key, int> */
function getArray(): array {
    return ['test' => 0];
}

function test(): array {
    $a = getArray();
    $b = [...$a];
    return $b;
}

Psalm output (using commit 42d3bce):

No issues!

https://psalm.dev/r/2ac2479ad5

<?php

/** @return array<string, int> */
function getArray(): array {
    return ['test' => 0];
}

function test(): array {
    $a = getArray();
    $b = [...$a];
    return $b;
}

Psalm output (using commit 42d3bce):

ERROR: DuplicateArrayKey - 10:14 - String keys are not supported in unpacked arrays