Add SSRF sinks and issue description #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasReschke
commented
Nov 17, 2020
| ## Further resources | ||
|
|
||
| - [OWASP Wiki for Server Side Request Forgery](https://owasp.org/www-community/attacks/Server_Side_Request_Forgery) | ||
| - [CWE-918](https://cwe.mitre.org/data/definitions/918) |
There was a problem hiding this comment.
I tried to keep this in the format that I'd like to see also for all other categories. (#4590)
LMK what you think.
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the sinks and issue description for:
curl_initcurl_setopt: Technically there is a bunch of settings that are not security sensitive. But I highly doubt there are realistic scenarios where someone has the third parameter user-controlled.Fixes #4594