$expr->name is not prefixed with $ #4554

LukasReschke · 2020-11-14T23:42:19Z

The example as-is would currently not flag the following code:

	public function foo() {
		$foo = $bad_data;
		\shell_exec($foo);
        }

Switching it to bad_data made it work.

The example as-is would currently not flag the following code: ``` public function foo() { $foo = $bad_data; \shell_exec($foo); } ``` Switching it to `bad_data` made it work.

muglug · 2020-11-16T01:28:31Z

Thanks!

The example as-is would currently not flag the following code: ``` public function foo() { $foo = $bad_data; \shell_exec($foo); } ``` Switching it to `bad_data` made it work.

$expr->name is not prefixed with $

bc762d9

The example as-is would currently not flag the following code: ``` public function foo() { $foo = $bad_data; \shell_exec($foo); } ``` Switching it to `bad_data` made it work.

muglug merged commit fd06167 into vimeo:master Nov 16, 2020

LukasReschke deleted the patch-1 branch November 16, 2020 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

$expr->name is not prefixed with $ #4554

$expr->name is not prefixed with $ #4554

LukasReschke commented Nov 14, 2020

muglug commented Nov 16, 2020

$expr->name is not prefixed with $ #4554

$expr->name is not prefixed with $ #4554

Conversation

LukasReschke commented Nov 14, 2020

muglug commented Nov 16, 2020