Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report fails to write in not yet existing folders #4353

Merged
merged 1 commit into from Oct 17, 2020

Conversation

pascalheidmann
Copy link
Contributor

Run psalm --report=in/a/subfolder/test.junit.xml somefile.php
This will result in an error like Warning: file_put_contents(in/a/subfolder/test.junit.xml): failed to open stream: No such file or directory in /app/src/Psalm/IssueBuffer.php on line 573 and the report will not be written.

This PR checks for the target dir and tries to create it otherwise.

@muglug muglug merged commit 37ab91a into vimeo:master Oct 17, 2020
@muglug
Copy link
Collaborator

muglug commented Oct 17, 2020

Thanks!

muglug pushed a commit that referenced this pull request Oct 19, 2020
Co-authored-by: Pascal Heidmann <heidmann@kigaroo.de>
@pascalheidmann pascalheidmann deleted the report-subfolder branch October 19, 2020 21:51
danog pushed a commit to danog/psalm that referenced this pull request Jan 29, 2021
Co-authored-by: Pascal Heidmann <heidmann@kigaroo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants