Not all code paths end in a return statement

[vudaltsov]

Since psalm 3.17 a function with a continue statement and a switch with returns is reported as invalid.

https://psalm.dev/r/b521fae60c

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b521fae60c

<?php

function a(): int
{
    switch (random_int(1, 10)) {
        case 1: 
            return 1;
        default:
            return 2;
    }
}


function b(): int
{
    foreach([1,2] as $i) {
    	continue;
    }
    
    switch (random_int(1, 10)) {
        case 1: 
            return 1;
        default:
            return 2;
    }
}

Psalm output (using commit 724b25b):

ERROR: InvalidReturnType - 14:15 - Not all code paths of b end in a return statement, return type int expected