add some more stubs for array functions #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-demb
reviewed
Oct 2, 2020
| * | ||
| * @psalm-pure | ||
| */ | ||
| function array_intersect_ukey(array $arr, array $arr2, array ...$arr3, callable $keyCompareFunc): array {} |
There was a problem hiding this comment.
Brackets mentioned twice
|
Please remove the six stubs that are already covered by return type providers in Psalm (currently |
|
@muglug done. Just for the sake of understanding, are return type providers used when annotations are not enough to type correctly the function? |
Yes, exactly. When I introduced conditional return types I removed (I think) all the return type providers that were simple enough to be implemented instead as conditional return types. |
|
Thanks! |
muglug
pushed a commit
that referenced
this pull request
Oct 7, 2020
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
muglug
pushed a commit
that referenced
this pull request
Oct 7, 2020
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more stubs for array functions