Exception with latest release

[dereuromark]

Uncaught UnexpectedValueException: $storage should not be null for Zend\Filter\Word\CamelCaseToDash::__invoke in phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Codebase/Methods.php:645

Stack trace:

#0 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php(196): Psalm\Internal\Codebase\Methods->getStorage(Object(Psalm\Internal\MethodIdentifier))

#1 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php(139): Psalm\Internal\Type\Comparator\CallableTypeComparator::getCallableFromAtomic(Object(Psalm\Codebase), Object(Psalm\Type\Atomic\TNamedObject), Object(Psalm\Type\Atomic\TCallable))

#2 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Type/Comparator/AtomicTypeComparator.php(255): Psalm\Internal\Type\Comparator\CallableTypeComparator::isNotExplicitlyCallableTypeCallable(Object(Psalm\Codebase), Object(Psalm\Type\Atomic\TNamedObject), Object(Psalm\Type\Atomic\TCallable), Object(Psalm\Internal\Type\Comparator\TypeComparisonResult))

#3 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Type/Comparator/UnionTypeComparator.php(71): Psalm\Internal\Type\Comparator\AtomicTypeComparator::isContainedBy(Object(Psalm\Codebase), Object(Psalm\Type\Atomic\TNamedObject), Object(Psalm\Type\Atomic\TCallable), false, true, Object(Psalm\Internal\Type\Comparator\TypeComparisonResult))

#4 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php(282): Psalm\Internal\Type\Comparator\UnionTypeComparator::isContainedBy(Object(Psalm\Codebase), Object(Psalm\Type\Union), Object(Psalm\Type\Union), true, true, Object(Psalm\Internal\Type\Comparator\TypeComparisonResult))

#5 phar:///home/travis/build/spryker/suite-nonsplit/vendor/psalm/phar/psalm.phar/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php(210): Psalm\Internal\Analyzer\Statements\Expression\Call\ArgumentAnalyzer::verifyType(Object(Psalm\Internal\Analyzer\StatementsAnalyzer), Object(Psalm\Type\Union), Object(Psalm\Type\Union), NULL, 'Zend\\Filter\\Fil...', 0, Object(Psalm\CodeLocation), Object(_HumbugBoxc22010bd12b9\PhpParser\Node\Expr\New_), Object(Psalm\Context), Object(Psalm\Storage\FunctionLikeParameter), false, NULL, false, false, Object(Psalm\CodeLocation))

[psalm-github-bot]

Hey @dereuromark, can you reproduce the issue on https://psalm.dev ?

[muglug]

Do you still get the error when running without the Phar? All that code in CallableTypeComparator is wrapped in a try/catch block, so this is at little mystifying

[weirdan]

All that code in CallableTypeComparator is wrapped in a try/catch block

Is it? The exception comes from here:

psalm/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php

Line 202 in 73f6fcd

$input_callable = self::getCallableFromAtomic($codebase, $input_type_part, $container_type_part);

and it doesn't seem to be wrapped into try/catch.

[muglug]

Really? Not

psalm/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php

Line 196 in 73f6fcd

$codebase->methods->getStorage($method_id);

?

[weirdan]

Nope. The code in phar has a lot of empty lines stripped and multi-line calls collapsed to single line. So the line 196 in phar corresponds to this:

psalm/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php

Line 323 in 73f6fcd

$method_storage = $codebase->methods->getStorage($invoke_id);

and line 139 (one stack frame above that) - to this:

psalm/src/Psalm/Internal/Type/Comparator/CallableTypeComparator.php

Line 202 in 73f6fcd

$input_callable = self::getCallableFromAtomic($codebase, $input_type_part, $container_type_part);

You can unpack the phar file with phar extract -f psalm.phar if you're interested.

[muglug]

You can unpack the phar file with phar extract -f psalm.phar if you're interested.

Oh awesome, did not know about this

[muglug]

@dereuromark are you running PHP 7.1 by any chance?

[muglug]

Yeah, this was fixed in PHP 7.2.19: https://bugs.php.net/bug.php?id=75186

[dereuromark]

7.2
but also fails for travis in
PHP 7.4.2 (cli) (built: Jan 24 2020 13:44:53) ( ZTS )

[drupol]

Thanks @muglug !