feature: universal object crates #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-feek
force-pushed
the
universal-object-crates
branch
from
d5d1c81
to
f1d7195
Compare
|
I'd like to also have an annotation for this. |
|
Looks great! Rebase to fix the build, sorry |
|
@weirdan annotation would be cool! A bit out of my grasp though, feel free to follow up with it |
mr-feek
force-pushed
the
universal-object-crates
branch
2 times, most recently
from
6e8e7ef
to
ffcfc1f
Compare
mr-feek
force-pushed
the
universal-object-crates
branch
from
ffcfc1f
to
22a144f
Compare
|
Sorry this took so long to merge, and thanks again! |
muglug
added a commit
that referenced
this pull request
Oct 7, 2020
* feature: universal object crates * docs: document universal object crate config option Co-authored-by: Matthew Brown <github@muglug.com>
muglug
added a commit
that referenced
this pull request
Oct 7, 2020
* feature: universal object crates * docs: document universal object crate config option Co-authored-by: Matthew Brown <github@muglug.com>
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* feature: universal object crates * docs: document universal object crate config option Co-authored-by: Matthew Brown <github@muglug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for implementing phpstan's concept of "universal object crates".
What do we think? I have yet to test with an actual config file, but the unit test I added is passing.