Treat methods of internal or psalm internal classes as internal #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both the method and the class are annotated as psalm-internal, but to different namespaces, we consider the method internal to whichever namespace is longer, i.e. the smaller code module. Issue reported at vimeo#3457
bdsl
commented
Jun 27, 2020
| @@ -2133,6 +2134,12 @@ private function registerFunctionLike(PhpParser\Node\FunctionLike $stmt, $fake_m | |||
|
|
|||
| $doc_comment = $stmt->getDocComment(); | |||
|
|
|||
|
|
|||
| if ($class_storage && ! $class_storage->is_trait) { | |||
There was a problem hiding this comment.
We don't take the internal nature of the trait into account, because that would fail these existing test cases for valid code:
psalm/tests/PsalmInternalAnnotationTest.php
Line 221 in b275606
psalm/tests/InternalAnnotationTest.php
Line 175 in b275606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both the method and the class are annotated as psalm-internal,
but to different namespaces, we consider the method internal to
whichever namespace is longer, i.e. the smaller code module.
Issue reported at #3457 by @skolman
I'd also like to gauge interest in
@internaland@psalm-internalmore generally. If people think it would be useful I could do some more work on catching the issues in the second list at #1623 (comment)