New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code location is nullable #3334

Merged

muglug merged 1 commit into vimeo:master from mr-feek:method-visibility-provider-param-update

May 11, 2020

Contributor

mr-feek commented May 10, 2020

Added MethodVisibilityProviderInterface to a class and immediately got

Uncaught TypeError: Argument 5 passed to Psalm\LaravelPlugin\ReturnTypeProvider\EloquentBuilderReturnTypeProvider::isMethodVisible() must be an instance of Psalm\CodeLocation, null given

https://github.com/vimeo/psalm/blob/master/src/Psalm/Internal/Provider/MethodVisibilityProvider.php#L81 has this marked as nullable


          fix: code location is nullable

b7934f1

muglug merged commit 7dd1823 into vimeo:master

Collaborator

muglug commented May 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment