MixedArgument for checked second array offset in 3.11.0

[vudaltsov]

https://psalm.dev/r/2284b270fa
The strange thing about this case is that the first array offset passes.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2284b270fa

<?php

/**
 * @todo psalm-immutable
 */
final class StudyJwtPayload
{
    public const USER_ID = 'usrid';
    public const STUDY_ID = 'studid';
    
    public string $userId;
    public string $studyId;

    public function __construct(string $userId, string $studyId)
    {
        $this->userId = $userId;
        $this->studyId = $studyId;
    }

    public static function fromClaims(array $claims): self
    {
        if (!isset($claims[self::USER_ID])) {
            throw new \InvalidArgumentException();
        }

        if (!\is_string($claims[self::USER_ID])) {
            throw new \InvalidArgumentException();
        }

        if (!isset($claims[self::STUDY_ID])) {
            throw new \InvalidArgumentException();
        }

        if (!\is_string($claims[self::STUDY_ID])) {
            throw new \InvalidArgumentException();
        }

        return new self($claims[self::USER_ID], $claims[self::STUDY_ID]);
    }
}

Psalm output (using commit 5bc9b09):

INFO: MixedArgument - 38:49 - Argument 2 of StudyJwtPayload::__construct cannot be mixed, expecting string

[muglug]

It's an issue with class constant offsets – explicit strings work fine: https://psalm.dev/r/772d804019

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/772d804019

<?php

/**
 * @todo psalm-immutable
 */
final class StudyJwtPayload
{
    public const USER_ID = 'usrid';
    public const STUDY_ID = 'studid';
    
    public string $userId;
    public string $studyId;

    public function __construct(string $userId, string $studyId)
    {
        $this->userId = $userId;
        $this->studyId = $studyId;
    }

    public static function fromClaims(array $claims): self
    {
        if (!isset($claims['usrid'])) {
            throw new \InvalidArgumentException();
        }

        if (!\is_string($claims['usrid'])) {
            throw new \InvalidArgumentException();
        }

        if (!isset($claims['studid'])) {
            throw new \InvalidArgumentException();
        }

        if (!\is_string($claims['studid'])) {
            throw new \InvalidArgumentException();
        }

        return new self($claims['usrid'], $claims['studid']);
    }
}

Psalm output (using commit 5bc9b09):

No issues!