allow setting php version from config or composer.json #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a composer.json is present and a PHP version requirement is configured, we set the php version to the minimal PHP version that satisfies the composer requirement. Additionally, this adds a `phpVersion` attribute to the <psalm> tag. If that's set, it takes precedence over what has been detected in composer.json. And finally, the --php-version command line flag continues to work and takes precedence over the setting in the <psalm> tag this fixes vimeo#2628
pilif
force-pushed
the
php-version-from-config
branch
from
559313a
to
2be6bbf
Compare
pilif
commented
Jan 30, 2020
| $php_version = $composer_json['require']['php'] ?? null; | ||
|
|
||
| if ($php_version) { | ||
| foreach (['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0'] as $candidate) { |
There was a problem hiding this comment.
I don't like having to do this loop here hard-coding versions, but IMHO there's no way to deterministically reverse a composer range to end up with a minimum version.
What still is a problem is that the knowledge of what versions of PHP psalm has actual support for isn't centralized but so far only existed in this regex here:
maybe for the future it would be worth to actually have proper API to get to this information so further duplication isn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a
composer.jsonis present and a PHP version requirement is configured, we set the php version to the minimal PHP version that satisfies the composer requirement.Additionally, this adds a
phpVersionattribute to the<psalm>tag. If that's set, it takes precedence over what has been detected incomposer.json.And finally, the
--php-versioncommand line flag continues to work and takes precedence over the setting in the<psalm>tagthis fixes #2628