@psalm-return non-empty-list in combination with @psalm-assert non-empty-list does not work since version 3.8.2

[smoench]

https://github.com/webmozart/assert using psalm. With latest psalm version I got following error report:

ERROR: InvalidReturnType - tests/static-analysis/assert-isNonEmptyList.php:10:18 - The declared return type 'non-empty-list<mixed>' for Webmozart\Assert\Tests\StaticAnalysis\consume is incorrect, got 'list<mixed>'
 * @psalm-return non-empty-list

ERROR: InvalidReturnStatement - tests/static-analysis/assert-isNonEmptyList.php:16:12 - The type 'list<mixed>' does not match the declared return type 'non-empty-list<mixed>' for Webmozart\Assert\Tests\StaticAnalysis\consume
    return $value;

Following code is being used (https://github.com/webmozart/assert/blob/master/tests/static-analysis/assert-isNonEmptyList.php)

/**
 * @psalm-param mixed $value
 *
 * @psalm-return non-empty-list<mixed>
 */
function consume($value): array
{
    Assert::isNonEmptyList($value);
    return $value;
}

to test (https://github.com/webmozart/assert/blob/master/src/Assert.php#L1736)

   /**
     * @psalm-assert non-empty-list $array
     *
     * @param mixed  $array
     * @param string $message
     *
     * @throws InvalidArgumentException
     */
    public static function isNonEmptyList($array, $message = '')
    {
        static::isList($array, $message);
        static::notEmpty($array, $message);
    }

While I was wondering why it fails I could track down something has changed with psalm version 3.8.2. I could prove psalm is not reporting any error with version <3.8.2.

[psalm-github-bot]

Hey @smoench, can you reproduce the issue on https://psalm.dev ?

[weirdan]

https://psalm.dev/r/2e692148a5

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2e692148a5

<?php
  class Assert {
     /**
     * @psalm-assert non-empty-list<mixed> $array
     *
     * @param mixed  $_array
     * @param string $_message
     * @return void
     *
     * @throws InvalidArgumentException
     */
    public static function isNonEmptyList($_array, $_message = '')
    {
    } 
}
/**
 * @psalm-param mixed $value
 *
 * @psalm-return non-empty-list<mixed>
 */
function consume($value): array
{
    Assert::isNonEmptyList($value);
    return $value;
}

Psalm output (using commit d434f7f):

INFO: MixedReturnStatement - 24:12 - Could not infer a return type

INFO: MixedInferredReturnType - 19:18 - Could not verify return type 'non-empty-list<mixed>' for consume

[smoench]

https://psalm.dev/r/c53305ee8b (this one produces the described error report; the other snippet has an incorrect doc block)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c53305ee8b

<?php
  class Assert {
    /**
     * @psalm-assert non-empty-list $array
     *
     * @param mixed  $array
     * @param string $message
     *
     * @throws InvalidArgumentException
     */
    public static function isNonEmptyList($array, $message = ''): void
    {
    } 
}
/**
 * @psalm-param mixed $value
 *
 * @psalm-return non-empty-list<mixed>
 */
function consume($value): array
{
    Assert::isNonEmptyList($value);
    return $value;
}

Psalm output (using commit d434f7f):

ERROR: InvalidReturnStatement - 23:12 - The type 'list<mixed>' does not match the declared return type 'non-empty-list<mixed>' for consume

ERROR: InvalidReturnType - 18:18 - The declared return type 'non-empty-list<mixed>' for consume is incorrect, got 'list<mixed>'