Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Method Psalm\Internal\LanguageServer\LanguageServer::cancelRequest() does not exist #10915

Open
mathroc opened this issue Apr 19, 2024 · 2 comments

Comments

@mathroc
Copy link
Contributor

mathroc commented Apr 19, 2024

Hi!

I saw this error in the vscode extension for Psalm, from what I understood it's not really an error. But something that an LSP client is trying to use that is not implemented.

So just posting this in case you think it's worth implementing.

I'm also not sure if it's something that shouldn't even be called according to the capabilities declared by the Psalm language server or not. (cc @tm1000)

Copy link

Hey @mathroc, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

@tm1000
Copy link
Contributor

tm1000 commented Apr 26, 2024

It's fine that it's called it just that in the world of Psalm there's nothing that can be canceled because the file parsers aren't async. Essentially you are saying "stop doing that thing" but by the time it actually does that the blocking action has already finished. I suppose that could be changed if the FileProvider is changed to async using ampphp but it's something that I think needs to wait until higher PHP 8.x is supported by Psalm itself.

Anyways not a bad thing to keep this open because we could just create a no-op and stop spamming the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants