Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

literal-string is non-empty-literal-string seems to be considered as always true #10911

Closed
VincentLanglet opened this issue Apr 17, 2024 · 2 comments · Fixed by #10912
Closed

literal-string is non-empty-literal-string seems to be considered as always true #10911

VincentLanglet opened this issue Apr 17, 2024 · 2 comments · Fixed by #10912

Comments

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Apr 17, 2024 •
edited

Hi, @orklah @weirdan

I was trying to fix #10909
and discovered an issue with conditional type which does block me.

https://psalm.dev/r/2d6c0230ed

 * @return (
 *    $s is non-empty-literal-string ? float : int
 * )

seems to give the same result than

 * @return (
 *    $s is literal-string ? float : int
 * )

like literal-string is non-empty-literal-string was always true...

This is the expected behavior https://phpstan.org/r/0ebe5412-7b05-4dd4-9ca3-2e5724c18c4f

Any idea where the fix need to be done ?
@psalm-github-bot Psalm Github bot
Copy link

I found these snippets:

https://psalm.dev/r/2d6c0230ed 
<?php

/**
 * @return (
 *    $s is non-empty-literal-string ? float : int
 * )
 */
function foo(string $s) {
    return 1.0; // Obviously wrong
}

/** @var literal-string $b */
$b
/** @psalm-trace $a */
$a = foo($b);

/** @var string $b */
$b
/** @psalm-trace $a */
$a = foo($b);
Psalm output (using commit 08afc45):

ERROR: ParseError - 15:1 - Syntax error, unexpected T_VARIABLE on line 15

ERROR: ParseError - 20:1 - Syntax error, unexpected T_VARIABLE on line 20

INFO: UnusedParam - 8:21 - Param s is never referenced in this method

INFO: Trace - 15:1 - $a: float

INFO: Trace - 20:1 - $a: float|int

INFO: UnusedVariable - 15:1 - $a is never referenced or the value is not used

INFO: UnusedVariable - 20:1 - $a is never referenced or the value is not used

@VincentLanglet VincentLanglet mentioned this issue Apr 18, 2024
Merged
@VincentLanglet
Copy link
Contributor Author

I found the reason #10912

@VincentLanglet VincentLanglet mentioned this issue Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conditional on non empty literal string VincentLanglet/psalm
1 participant
@VincentLanglet