Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Refreshing With Cookies example has a bug #454

Open
bokolob opened this issue Oct 21, 2021 · 1 comment
Open

Implicit Refreshing With Cookies example has a bug #454

bokolob opened this issue Oct 21, 2021 · 1 comment

Comments

@bokolob
Copy link

bokolob commented Oct 21, 2021

There is a possible conflict between logout and token prolongation. In the actual example, a new access cookie could be set after the logout request.

@vimalloc
Copy link
Owner

That's interesting. Thanks for catching that. It should be really easy to add an extra guard for that, I'll take a look at updating some stuff in the example to prevent that when I have some time. Two options to fix this off the top of my head:

  • We should be able to look at the cookies being set on the response, and not refresh the jwt if there is already an unset cookie present.
  • We can look at the request and do not do implicit refreshing if it's the logout endpoint that is being hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants