Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported cryptography version #452

Closed
decaz opened this issue Oct 7, 2021 · 4 comments
Closed

Supported cryptography version #452

decaz opened this issue Oct 7, 2021 · 4 comments

Comments

@decaz
Copy link
Contributor

decaz commented Oct 7, 2021

extras_require={"asymmetric_crypto": ["cryptography>=3.0,<4.0"]},

There is a new version scheme is being used by cryptography: https://cryptography.io/en/latest/api-stability/#versioning.

@vimalloc
Copy link
Owner

vimalloc commented Oct 8, 2021

Thanks for making me aware of this. 👍

@decaz
Copy link
Contributor Author

decaz commented Oct 8, 2021

@vimalloc could you release a new version, please?

@vimalloc
Copy link
Owner

vimalloc commented Oct 8, 2021

@decaz done, it should be publishing and available on pypi momentarily 👍

@smarlowucf
Copy link
Contributor

smarlowucf commented Feb 18, 2022

Is there a reason (compatibility wise) to lock the version bounds though? If this package works with older versions of cryptography it would be ideal to support that option. Unnecessarily locking requirement bounds makes it difficult to package downstream where a given distribution might have an older version of cryptography.

Having the version locked like this conveys that you "need" cryptography>={some_version} for flask-jwt-extended to work but based on the commit history it doesn't seem like this is actually the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants