Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support to pass additional headers in JWT encoding the token #276

Merged
merged 4 commits into from Oct 4, 2019
Merged

added support to pass additional headers in JWT encoding the token #276

merged 4 commits into from Oct 4, 2019

Conversation

iamajay
Copy link
Contributor

@iamajay iamajay commented Sep 24, 2019

added support to pass additional headers in JWT encoding the token and added the function to return unverified headers from an encoded token

@iamajay
added support to pass additional headers in JWT encoding the token an…
43e3694 
…d added the function to return unverified headers from a encoded token
@coveralls
Copy link

coveralls commented Sep 24, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling f5bebf5 on iamajay:master into 7f39a44 on vimalloc:master.

@iamajay iamajay mentioned this pull request Sep 24, 2019
Closed
vimalloc
vimalloc requested changes Sep 25, 2019
View reviewed changes
Copy link
Owner

@vimalloc vimalloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I've left comments on a couple minor things if you don't mind taking a peak at them.

flask_jwt_extended/utils.py Outdated Show resolved Hide resolved
tests/test_decode_tokens.py Outdated Show resolved Hide resolved
flask_jwt_extended/utils.py Show resolved Hide resolved
@iamajay
Copy link
Contributor Author

iamajay commented Sep 25, 2019

This is looking good! I've left comments on a couple minor things if you don't mind taking a peak at them.

Thanks for the reviews will surely resolve and improve the things in this PR.

@pep8speaks
Copy link

pep8speaks commented Sep 30, 2019 •
edited

Hello @iamajay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-01 08:54:31 UTC

@iamajay iamajay requested a review from vimalloc October 1, 2019 08:57
@vimalloc vimalloc merged commit e182953 into vimalloc:master Oct 4, 2019
@vimalloc
Copy link
Owner

vimalloc commented Oct 4, 2019

Sorry it took so long to review this, been a very busy week for me. This looks great, thank you so much for contributing! I'll get a new release pushed out with these changes ASAP! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimalloc vimalloc vimalloc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamajay @coveralls @pep8speaks @vimalloc