forked from koajs/koa
-
Notifications
You must be signed in to change notification settings - Fork 0
/
onerror.js
260 lines (207 loc) · 6.33 KB
/
onerror.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
'use strict';
const assert = require('assert');
const request = require('supertest');
const Koa = require('../..');
const context = require('../helpers/context');
describe('ctx.onerror(err)', () => {
it('should respond', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
ctx.throw(418, 'boom');
});
const server = app.listen();
return request(server)
.get('/')
.expect(418)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Content-Length', '4');
});
it('should unset all headers', async() => {
const app = new Koa();
app.use((ctx, next) => {
ctx.set('Vary', 'Accept-Encoding');
ctx.set('X-CSRF-Token', 'asdf');
ctx.body = 'response';
ctx.throw(418, 'boom');
});
const server = app.listen();
const res = await request(server)
.get('/')
.expect(418)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Content-Length', '4');
assert.equal(res.headers.hasOwnProperty('vary'), false);
assert.equal(res.headers.hasOwnProperty('x-csrf-token'), false);
});
it('should set headers specified in the error', async() => {
const app = new Koa();
app.use((ctx, next) => {
ctx.set('Vary', 'Accept-Encoding');
ctx.set('X-CSRF-Token', 'asdf');
ctx.body = 'response';
throw Object.assign(new Error('boom'), {
status: 418,
expose: true,
headers: {
'X-New-Header': 'Value'
}
});
});
const server = app.listen();
const res = await request(server)
.get('/')
.expect(418)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('X-New-Header', 'Value');
assert.equal(res.headers.hasOwnProperty('vary'), false);
assert.equal(res.headers.hasOwnProperty('x-csrf-token'), false);
});
it('should ignore error after headerSent', done => {
const app = new Koa();
app.on('error', err => {
assert.equal(err.message, 'mock error');
assert.equal(err.headerSent, true);
done();
});
app.use(async ctx => {
ctx.status = 200;
ctx.set('X-Foo', 'Bar');
ctx.flushHeaders();
await Promise.reject(new Error('mock error'));
ctx.body = 'response';
});
request(app.callback())
.get('/')
.expect('X-Foo', 'Bar')
.expect(200, () => {});
});
it('should set status specified in the error using statusCode', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
const err = new Error('Not found');
err.statusCode = 404;
throw err;
});
const server = app.listen();
return request(server)
.get('/')
.expect(404)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Not Found');
});
describe('when invalid err.statusCode', () => {
describe('not number', () => {
it('should respond 500', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
const err = new Error('some error');
err.statusCode = 'notnumber';
throw err;
});
const server = app.listen();
return request(server)
.get('/')
.expect(500)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Internal Server Error');
});
});
});
describe('when invalid err.status', () => {
describe('not number', () => {
it('should respond 500', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
const err = new Error('some error');
err.status = 'notnumber';
throw err;
});
const server = app.listen();
return request(server)
.get('/')
.expect(500)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Internal Server Error');
});
});
describe('when ENOENT error', () => {
it('should respond 404', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
const err = new Error('test for ENOENT');
err.code = 'ENOENT';
throw err;
});
const server = app.listen();
return request(server)
.get('/')
.expect(404)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Not Found');
});
});
describe('not http status code', () => {
it('should respond 500', () => {
const app = new Koa();
app.use((ctx, next) => {
ctx.body = 'something else';
const err = new Error('some error');
err.status = 9999;
throw err;
});
const server = app.listen();
return request(server)
.get('/')
.expect(500)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Internal Server Error');
});
});
});
describe('when non-error thrown', () => {
it('should response non-error thrown message', () => {
const app = new Koa();
app.use((ctx, next) => {
throw 'string error'; // eslint-disable-line no-throw-literal
});
const server = app.listen();
return request(server)
.get('/')
.expect(500)
.expect('Content-Type', 'text/plain; charset=utf-8')
.expect('Internal Server Error');
});
it('should use res.getHeaderNames() accessor when available', () => {
let removed = 0;
const ctx = context();
ctx.app.emit = () => {};
ctx.res = {
getHeaderNames: () => ['content-type', 'content-length'],
removeHeader: () => removed++,
end: () => {},
emit: () => {}
};
ctx.onerror(new Error('error'));
assert.equal(removed, 2);
});
it('should stringify error if it is an object', done => {
const app = new Koa();
app.on('error', err => {
assert.equal(err, 'Error: non-error thrown: {"key":"value"}');
done();
});
app.use(async ctx => {
throw {key: 'value'}; // eslint-disable-line no-throw-literal
});
request(app.callback())
.get('/')
.expect(500)
.expect('Internal Server Error', () => {});
});
});
});