Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow to pause by tapping on the player screen on touch screen in Windows #8608

Open
tomasz1986 opened this issue Feb 26, 2024 · 2 comments
Labels
needs: triage This issue needs to be reviewed

Comments

@tomasz1986
Copy link

Description

This issue has been reported at iv-org/invidious#4447 first.

Basically, I use Invidious (which uses this player) on a 8" touch screen Windows tablet. The play/pause button is very small and as such difficult to press using a finger, so I would like to be able to press directly on the screen in order to play and pause videos.

As with other video players (e.g. YouTube), I expect the player to respond to finger presses. However, the current situation is that only the control bar pops up when you press the screen with a finger, with no play/pause action being performed. Because of this, the only way to play or pause a video is to press directly on the play/pause button.

The above is not true when using a mouse, where you can press anywhere to perform the play/pause action. Yet, the player behaves differently when operated with a finger. Please keep in mind that this affects Windows on touch screen specifically, and not a strictly mobile environment like Android or iOS.

Reduced test case

https://videojs.com

Steps to reproduce

  1. On a touch screen Windows device, open the demo video from https://videojs.com.
  2. Try to play and pause it using your finger to press on the screen.
  3. The video doesn't respond to the presses unless you press the buttons on the bottom bar.

I don't feel like recording yet another video for this, but you can see the very behaviour on the video recorded for the issue in the Invidious repository below:

1.mp4

Errors

No response

What version of Video.js are you using?

v7 and v8

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chromium 122

What OS(es) and version(s) does this occur with?

Windows 10

@tomasz1986 tomasz1986 added the needs: triage This issue needs to be reviewed label Feb 26, 2024
Copy link

welcome bot commented Feb 26, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mister-ben
Copy link
Contributor

This would require changes to the listeners set up here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants