Report only 1 FRAG_PARSING_ERROR per parsed TS file #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
approved these changes
Jan 13, 2022
albertdaurell
deleted the
feature/report_one_frag_parsing_error_per_ts
branch
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Improve error reporting
Why is this Pull Request needed?
In order to improve error reporting we want to report only one
FRAG_PARSING_ERRORper parsedTS.Are there any points in the code the reviewer needs to double check?
-
Resolves issues:
#4469
Checklist