Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release windows amd64 binary #4

Closed
gitfool opened this issue Jun 23, 2021 · 5 comments
Closed

Release windows amd64 binary #4

gitfool opened this issue Jun 23, 2021 · 5 comments

Comments

@gitfool
Copy link

gitfool commented Jun 23, 2021

Would you please release a windows amd64 binary too?

@vetyy
Copy link
Owner

vetyy commented Jun 24, 2021

Hey @gitfool , I released a new version (v0.1.4) with windows binary, please test it and let me know if everything is okay. I don't really have a windows machine available right now.

@gitfool
Copy link
Author

gitfool commented Jun 24, 2021

@vetyy thanks a lot, it worked!

Notes:

  • I had to manually drop in the tarball since plugin install is broken on windows
  • tarball is not structured correctly; I had to move helmecr.exe to bin/helmecr.exe
  • ... it looks like all 0.1.4 tarballs are not structured correctly (whereas all 0.1.3 tarballs are)
  • version was not bumped to 0.1.4 in the plugin.yaml (to match release)

@gitfool
Copy link
Author

gitfool commented Jun 29, 2021

@vetyy sorry to bother you but would you be able to fix the above issues and make another release? 🙏

@vetyy
Copy link
Owner

vetyy commented Jun 30, 2021

sorry @gitfool I was really busy this week, I fixed existing release of 0.1.4 can you test it now please?

@gitfool
Copy link
Author

gitfool commented Jun 30, 2021

@vetyy LGTM; thanks!

@gitfool gitfool closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants