Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enhancement ideas #82

Open
jmartschinke opened this issue Mar 1, 2021 · 1 comment
Open

Some enhancement ideas #82

jmartschinke opened this issue Mar 1, 2021 · 1 comment

Comments

@jmartschinke
Copy link
Contributor

It seems to me that many of the currently active issues arise because of the cloning of the original method. There is also still some missing debug information in certain circumstances, which I will report later.
I tried to change it locally so that instead of weaving like this:

OnEntry();
try
{
   $_executor_Foo();
}
catch (Exception ex)
{
   OnException();
}
OnExit();

this would be woven:

OnEntry();
try
{
   // content of foo directly here instead of a call
}
catch (Exception ex)
{
   OnException();
}
OnExit();

I could only partially get that to work. The OnEntry() and the content of the Method get called, but OnExit() is not and i cannot get the decompiled sources.

Perhaps we could work together to look into this solution?

@Ralf1108
Copy link
Collaborator

Ralf1108 commented Mar 1, 2021

The original design choice was to move the original method into another method and just call it. As we are no MSIL expert we didn't want to complicate the weaving process.
But you are right, this messes up the debug informations.

If you need help can you specify what exact problem you encounter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants