Issue66/invalid program exception #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 21, 2022 07:56
…cialAspectMethods namespacing
…ceptions at runtime
Current changes fix the InvalidProgramException defect for if and if-else block method bodies. This will allow a PR to be merged fixing these conditions. Another branch will be created demonstrating the try-catch issue and hopefully a fix can be created from that.
Adds tests proving using, switch and foreach blocks do not error.
|
Was able to verify and fix all reported sources of InvalidProgramException defects. This now fixes issue #97 as well. |
This was referenced Oct 4, 2022
|
Wow, great work @psaxton !!! Thank you very much! I will trigger a prerelease nuget-package so the other guys can verify that their issues are solved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #66: The original issue was caused with methods ending in a if-else block. Later reports show try-catch and try-finally blocks also result in an InvalidProgramException, but this apparently has a different cause and is reported on its own in #97.
I don't know how the maintainers want to continue to track the defects (close #66 and keep #97 open; keep #66 and close #97 as dup; etc.), but figured it is worth fixing at least this cause of the exception.