[Windows] Support for Visual Studio 2019

[ibc]

Here a fork of mediasoup adding support for VS 2019. It seems that gyp is not doing it correctly so this fork modified gyp files:

• aoslee@1fa4055

Does it make sense? If so, we should send a PR to gyp project in Google Source Code:

• https://bugs.chromium.org/p/gyp/issues

Related issue in GYP project:

• node-gyp is unable to find msbuild if VS2019 is installed.  nodejs/node-gyp#1663

/CC @haiyangwu

[haiyangwu]

• aoslee@1fa4055 this commit makes sense and made it work to generate Visual Studio 2019 Project Struct.

• gyp@eb296f67da This is the similar code from gyp project in Google Source Code.

@ibc In my opinion, merging this commit is better for there's no timeline gyp project add this feature.

[ibc]

Thanks. However, honestly I wouldn't like to have a modified version of gyp within mediasoup. I just want to run ./scripts/get-dep.sh gyp (being in mediasoup/worker/ folder) from time to time without having to worry about re-applying local changes again and again.

In the past we had a problem in gyp due to issues with Python3:

• https://bugs.chromium.org/p/gyp/issues/detail?id=36#c59

@saghul fixed it and I commented his patch into the issue:

• https://bugs.chromium.org/p/gyp/issues/detail?id=36#c59

Finally, they added it to master branch:

• https://chromium.googlesource.com/external/gyp/+/da63cb0ffdbcedd0231ffac027adf1bce7391391%5E%21/
• https://chromium.googlesource.com/external/gyp/+/4f1618abf348fea8a58555841a26518899a57f0a%5E%21/

However, we were told to upload patches as peer here. So, I expect that if a "PR" is sent it will be accepted.

Does it make sense?

[haiyangwu]

without having to worry about re-applying local changes again and again

Agree and it makes sense. 😏

[ibc]

Hi, somehow I've changed a bit my mind. Once there is a PR in gyp project, I'm open to modify the gyp source code in mediasoup and wait for gyp to adopt the PR. The same applies to the other Windows related project (in case it has any relationship with gyp).

[ibc]

Hi, any progress on this? Has been the issue reported to GYP project?

NOTE: https://gyp.gsrc.io/docs/Hacking.md

[ibc]

Ok, I've created the CL:

• https://chromium-review.googlesource.com/c/external/gyp/+/1982599

Please comment on it if possible. Note that, if any developer asks me, I won't be able to explain anything (I've just copied the change above, I cannot test in Windows and never used MSV).

[ibc]

I've pushing a new branch issue-347 with the above exact commit:

• d739ef6

I'd like that the CL uploaded to GYP project is approved (so we don't need to manage our "own" GYP source code). Anyway, if you guys confirm that the branch is ok, I'll merge into v3.

[ibc]

UPDATE: I've merged (and then deleted) the issue-347 into v3 and released in mediasoup 3.4.8.

Let's keep this issue open to remember that, in theory, we are waiting got GYP to accept the CL, so we don't have to manage our own modified GYP sources:

• https://chromium-review.googlesource.com/c/external/gyp/+/1982599

[ibc]

Just decided to drop gyp and move to CMake. See #359.

[james133]

support cmake vc2019,xcode,clion
https://github.com/yanhua133/mediasoup-sfu-cpp

[jmillan]

No idea what that is about @james133.

[nazar-pc]

We moved away from GYP as a build system, so this particular issue should now be irrelevant, closing.