Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark vitest as an optional peer dependency with peerDependenciesMeta #283

Closed
ericmatthys opened this issue Nov 2, 2023 · 1 comment
Closed

Comments

@ericmatthys
Copy link

Similar to the reasoning in jest-community/eslint-plugin-jest#970, a shareable ESLint config does not need to depend directly on vitest. For example, in a monorepo it's common to have a package that contains the ESLint config for the rest of the packages in the monorepo. This package has no need to depend on vitest except to satisfy peer dependency errors from eslint-plugin-vitest.

@veritem
Copy link
Owner

veritem commented Nov 3, 2023

thank for bringing this up! it should be fixed in latest version.

@veritem veritem closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants