feat: add migrateToSecureLegacySignature property #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10791281 | Triggered | Generic High Entropy Secret | d0c68d8 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | d0c68d8 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | d0c68d8 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | d0c68d8 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | aeb9cb2 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | aeb9cb2 | packages/config/test/config.spec.ts | View secret |
| 10791281 | Triggered | Generic High Entropy Secret | aeb9cb2 | packages/config/test/config.spec.ts | View secret |
| 10791282 | Triggered | Generic High Entropy Secret | d0c68d8 | packages/auth/test/auth.spec.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
juanpicado
force-pushed
the
migrateToSecureLegacySignature-prop
branch
from
df0301a
to
ba179bc
Compare
juanpicado
force-pushed
the
migrateToSecureLegacySignature-prop
branch
from
ba179bc
to
d0c68d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Node.js 22 the API
crypto.createCipheris not longer available and leads to crash the server due there is no fallback available to the new and moderncrypto.createCipherivfor legacy token signature. Due might be a breaking change force all users to restore tokens and update the database secret manually, the new propertymigrateToSecureLegacySignatureIt allows users to migrate automatically to the new tokens signature, older configurations still running in Node.js 21 or lower would see a warning in the console.
If any user upgrades to Node.js 22 or higher will be force to update the token and will start using the new legacy signature token which is secure due tokens have salt and are never equal.
info --- config file - /Users/user/.config/verdaccio/config.yaml fatal--- uncaught exception, please report this Error: Invalid storage secret key length, must be 32 characters long but is 64. The secret length in Node.js 22 or higher must be 32 characters long. Please consider generate a new one. Learn more at https://verdaccio.org/docs/configuration/#.verdaccio-db at Config.checkSecretKey (/Users/user/projects/verdaccio.5.x/.yarn/cache/@verdaccio-config-npm-0.0.0-20240505134815-1b8406e5a2-6a5cb3a4b4.zip/node_modules/@verdaccio/config/src/config.ts:198:17)migrateToSecureLegacySignatureto help older versions to migrate the new signature and more secure systemnpm loginfails #4601