Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer support #35

Open
guybedford opened this issue May 20, 2019 · 0 comments
Open

Puppeteer support #35

guybedford opened this issue May 20, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@guybedford
Copy link
Contributor

This would need to be supported as its own emission case, inlining the logic from lib/Launcher.js:

const browserFetcher = new BrowserFetcher(this._projectRoot);
...
browserFetcher.revisionInfo(this._preferredRevision);

where this._preferredRevision comes from the package.json file in node_modules/puppeteer-core/package.json puppeteer.chrome_revision property.

The internal logic of BrowserFetcher then does a join on the metadata to construct the path of the form - ${base}${os}-${revision} where base is node_modules/puppeteer/.local-chromium. Simply emitting this folder would be sufficient for support.

@guybedford guybedford added the enhancement New feature or request label May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant