feat: styled-jsx as client-only for rsc #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
changed the title
ijjk
reviewed
Oct 14, 2022
ijjk
approved these changes
Oct 17, 2022
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Ooo exciting! Congrats on 5.1.0 👍👍 |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 19, 2022
For css-in-js libs like styled-jsx we don't recommend to use on server side since it will blow up the rsc payload during navigation. This upgration of styled-jsx includes `client-only` as dependency so that it will throw when it's been used on serevr layer x-ref: vercel/styled-jsx#816
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
For css-in-js libs like styled-jsx we don't recommend to use on server side since it will blow up the rsc payload during navigation. This upgration of styled-jsx includes `client-only` as dependency so that it will throw when it's been used on serevr layer x-ref: vercel/styled-jsx#816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
import "client-only"to mark styled-jsx as client only packages for server components, so that when users try to import it on server layer it will error in next.jsExpected error if you use styled-jsx in server components rather than client components
x-ref: vercel/next.js#41414